Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create pet avatar component #261

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

nathalia-84
Copy link
Contributor

@nathalia-84 nathalia-84 commented Jun 10, 2024

Closes #231

Feature

Create Pet Avatar component and display it in Home.

Visual evidences 🖼️
Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Additional info N/A

src/home/components/SideMenu/index.js Outdated Show resolved Hide resolved
src/components/PetAvatar/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Os avatares ainda estào com o underline! Precisamos tirar

Ta faltando resolver o caso de mais de 3 pets também, ele precisa ficar um em baixo do outro conforme conversamos e por enquanto simplesmente stackar as linhas

src/components/PetAvatar/index.js Outdated Show resolved Hide resolved
src/home/components/SideMenu/index.scss Outdated Show resolved Hide resolved
src/stories/PetAvatar.stories.js Show resolved Hide resolved
src/components/PetAvatar/index.scss Outdated Show resolved Hide resolved
@nathalia-84
Copy link
Contributor Author

Comentários resolvidos!

@nathalia-84 nathalia-84 requested a review from Alecell June 16, 2024 19:25
@DominMFD
Copy link
Contributor

DominMFD commented Jun 17, 2024

Seria legal vc ver com o Eliabe um hover para o seu componente, mas é so uma sugestão, ele ta bom, pra mim ta aprovado, parabéns!!!

@nathalia-84
Copy link
Contributor Author

Seria legal vc ver com o Eliabe um hover para o seu componente, mas é so uma sugestão, ele ta bom, pra mim ta aprovado, parabéns!!!

Hover adicionado!

Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Achei estranho que no storybook ta estranho o componente a pesar de que na página ele ta certo, consegue dar uma olhada?

src/components/PetAvatar/index.scss Outdated Show resolved Hide resolved
src/layouts/app/components/SideMenu/index.scss Outdated Show resolved Hide resolved
src/layouts/app/components/SideMenu/index.js Show resolved Hide resolved
src/components/PetAvatar/index.scss Outdated Show resolved Hide resolved
@nathalia-84
Copy link
Contributor Author

Comentários resolvidos!

@nathalia-84 nathalia-84 requested a review from Alecell July 8, 2024 11:14
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só to achando o component no storybook meio estranho ainda x.x

@nathalia-84
Copy link
Contributor Author

@Alecell, corrigi aquilo que conversamos ainda a pouco, a correção não quebrou o componente

@Alecell Alecell merged commit 1852a4e into devhatt:main Jul 24, 2024
3 checks passed
gustavogularte pushed a commit to gustavogularte/pet-dex-frontend that referenced this pull request Jul 24, 2024
* feat: create pet avatar component

* feat: create pet avatar component

* feat: create pet avatar component

* feat: create pet avatar component

* feat: create pet avatar component

* feat: create pet avatar component

* feat: create pet avatar component

---------

Co-authored-by: Alexandre Gomes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Componente Pet Avatar
4 participants